Skip to content

docs(sonarqube): sync template standards updates#363

Merged
mberlofa merged 1 commit into
mainfrom
docs/sonarqube-template-standards-sync
Jul 6, 2026
Merged

docs(sonarqube): sync template standards updates#363
mberlofa merged 1 commit into
mainfrom
docs/sonarqube-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 4, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Document networkPolicy.egress.extraEgress and extraManifests for SonarQube.
  • Add SonarQube playground allowlist coverage and NetworkPolicy extra egress controls.
  • Keep the chart docs aligned with the template standards update in fix(sonarqube): align template standards charts#685.

Related

Validation

  • npm run lint
  • npm run format:check
  • npm run build
  • make site-sync-check CHART=sonarqube
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features

    • Added a new collapsible Network Policy section for the SonarQube chart in the playground, including options for enabling egress rules, setting an extra destination CIDR, and specifying an extra TCP port.
    • Introduced support for rendering additional extension manifests, with documentation and examples.

  • Documentation

    • Expanded the SonarQube chart docs with the new Network Policy options and extraManifests usage.
    • Added examples showing how to include extra Kubernetes resources and egress rules.

@mberlofa mberlofa mentioned this pull request Jul 4, 2026
Merged
@coderabbitai

coderabbitai Bot commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b529ac5a-6759-4d0f-bf93-1d2cc54d8530

📥 Commits

Reviewing files that changed from the base of the PR and between cd5ef08 and dbd7cc9.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/sonarqube.mdx
  • src/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/sonarqube.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/pages/playground.astro
  • src/data/playground-configs.ts
📝 Walkthrough

Walkthrough

This PR adds a Network Policy egress configuration section to the sonarqube playground config, registers the sonarqube chart in the playground site-sync lookup, and updates the sonarqube chart documentation to describe networkPolicy.egress.extraEgress and extraManifests.

Changes

SonarQube egress/extraManifests support

Layer / File(s) Summary
Playground network policy config and registration
src/data/playground-configs.ts, src/pages/playground.astro		 Adds a gated Network Policy section with extra egress CIDR/port fields to the sonarqube playground config and registers sonarqube in siteSyncPlaygroundConfigs.
Documentation for extraEgress and extraManifests
src/pages/docs/charts/sonarqube.mdx		 Adds a Key Features bullet, extends the production NetworkPolicy example with extraEgress, adds an Extension Manifests section, and expands the Values table with networkPolicy.egress.extraEgress and extraManifests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#345: Both PRs update src/data/playground-configs.ts and the playground registry to introduce or describe networkPolicy.egress.extraEgress-style options.
  • helmforgedev/site#353: Both PRs add a networkPolicy.enabled Network Policy section, document extraManifests, and wire the chart into siteSyncPlaygroundConfigs.
  • helmforgedev/site#355: Both PRs add and document networkPolicy.egress.extraEgress support in the playground config and chart docs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the SonarQube docs sync with template standards updates.
Description check ✅ Passed The description covers the summary, validation, and related issue, and is close enough to the template despite minor heading differences.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/sonarqube-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa mentioned this pull request Jul 4, 2026
Closed
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
@mberlofa
fix(sonarqube): align template standards (#685)
c94165b 
## Summary

- keep the Helm test hook under `templates/tests` so `helm test` remains
functional
- add `networkPolicy.egress.extraEgress` and `extraManifests` support
with schema and unit coverage
- make k3d CI fixtures self-contained for IPv4, external PostgreSQL,
External Secrets, and plugin init validation
- expand NOTES and README coverage for the new operational controls

## Validation

- `make validate-chart CHART=sonarqube TIMEOUT=1200`: FULLY VALIDATED
(18 layers), including k3d behavioral scenarios for default, dual-stack,
external-db, external-secrets, gateway-api, hardening, ingress, plugins,
and smoke.
- `make site-sync-check CHART=sonarqube`
- `make release-check REPO=charts` passed with the expected GR-077
post-merge release confirmation warning.
- `make attribution-check REPO=charts`

Site PR: helmforgedev/site#363
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added `extraManifests` support to include additional resources in the
release.
* Enhanced NetworkPolicy egress with `networkPolicy.egress.extraEgress`
and improved conditional egress rendering.
* **Bug Fixes**
* Refined CI configurations for external database and external secrets
wiring.
  * Updated CI service networking to use IPv4 single-stack.
* **Documentation**
* Improved README and in-chart notes, including clearer
NetworkPolicy/value descriptions.
* **Tests**
* Expanded operations tests to cover extra manifests and NetworkPolicy
egress scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/sonarqube-template-standards-sync branch from cd5ef08 to dbd7cc9 Compare July 6, 2026 16:34
@mberlofa mberlofa merged commit de2f876 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/sonarqube-template-standards-sync branch July 6, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mberlofa